[blivet:rhel7 2/2] Clean up tests added in previous commits

Anne Mulhern amulhern at redhat.com
Tue Mar 11 12:08:51 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Tuesday, March 11, 2014 4:04:59 AM
> Subject: Re: [blivet:rhel7 2/2] Clean up tests added in previous commits
> 
> On Tue, 2014-03-04 at 13:07 -0500, mulhern wrote:
> > Modify or adjust tests on rhel7-branch that were introduced in the previous
> > commit that fail.
> > 
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  tests/clearpart_test.py              |  2 +-
> >  tests/devicefactory_test.py          |  9 +---
> >  tests/devicelibs_test/mdraid_test.py |  7 ---
> >  tests/devices_test.py                | 86
> >  +-----------------------------------
> >  tests/udev_test.py                   |  2 +
> >  5 files changed, 6 insertions(+), 100 deletions(-)
> > 
> > diff --git a/tests/clearpart_test.py b/tests/clearpart_test.py
> > index 1486bde..6235965 100644
> > --- a/tests/clearpart_test.py
> > +++ b/tests/clearpart_test.py
> > @@ -118,7 +118,7 @@ class ClearPartTestCase(unittest.TestCase):
> >          self.assertFalse(b.shouldClear(sdc),
> >                           msg="type linux should not clear unformatted
> >                           disks "
> >                               "unless initlabel is set")
> > -        self.assertFalse(b.shouldClear(sdd),
> > +        self.assertTrue(b.shouldClear(sdd),
> >                           msg="type linux should not clear disks with empty
> >                           "
> >                               "partition tables unless initlabel is set")
> I think the check and the msg are out of sync with this change.
> 
> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Fixed in working copy.

- mulhern


More information about the anaconda-patches mailing list