[blivet:rhel7/master 3/3] Remove action_test.py

Vratislav Podzimek vpodzime at redhat.com
Tue Mar 11 08:00:31 UTC 2014


On Tue, 2014-03-04 at 14:11 -0500, mulhern wrote:
> The compelling reason for removing it is that it corrupts subsequently run
> unit tests with Mock values even when it is not itself run, by importing
> storagetestcase.py. This is obvious with tests that must be run as root,
> I don't guarantee that it happens for other tests.
> 
> There are alternatives, like renaming action_test.py, or making a more
> complicated directory structure to hide it, or discovering it separately from
> all the other tests. But until it is fixed so it can be run that extra
> ingenuity seems like overkill.
Can't we just use some unittest.* decorator to make it not run by
default? I'm afraid that if it disappears from the tree it will hardly
get an attention later.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list