[PATCH] Allow NTFS to be mountable. (#748780)

Brian C. Lane bcl at redhat.com
Mon Mar 10 19:02:41 UTC 2014


On Mon, Mar 10, 2014 at 10:03:28AM -0400, David Shea wrote:
> Back in the time of Fedora 14, anaconda marked NTFS volumes as
> unmountable, because any attempt to mount them would hang in the mount
> wrapper in imount.c. Because NTFS is handled through fuse, an instance
> of mount.ntfs stays running after the mount operation is completed, and
> mount.ntfs does not property daemonize: it leaves stdout and stderr
> open, so we were getting stuck trying to read from what should have been
> closed file descriptors.
> 
> mount.ntfs still does this, but the problem has been twice fixed
> elsewhere: /bin/mount closes its stdout and stderr--which closes the
> copies attached to anaconda's pipes--when it exits, and the python code
> we now use in place of imount pays attention to SIGCHLD, so it stops
> trying to read output when mount exits whether the file descriptors are
> still open or not. So we can mount ntfs partitions now if anyone wants
> them.
> ---
>  blivet/formats/fs.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
> index 2e2faeb..7b0807b 100644
> --- a/blivet/formats/fs.py
> +++ b/blivet/formats/fs.py
> @@ -1358,10 +1358,6 @@ class NTFS(FS):
>      _existingSizeFields = ["Cluster Size:", "Volume Size in Clusters:"]
>      partedSystem = fileSystemType["ntfs"]
>  
> -    @property
> -    def mountable(self):
> -        return False
> -
>      def _fsckFailed(self, rc):
>          if rc != 0:
>              return True
> -- 
> 1.8.5.3

Ack.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list