[rhel7-branch][PATCH] Keep selection when switching environments

Martin Kolman mkolman at redhat.com
Fri Mar 7 15:52:54 UTC 2014


On Fri, 2014-03-07 at 09:27 +0100, Vratislav Podzimek wrote:
> On Thu, 2014-03-06 at 17:28 +0100, Martin Kolman wrote:
> > As master has addon switching handled differently due to newer GTK,
> > this is rhel7-branch (and most probably 7.1 due to the GUI changes) only.
> > 
> > The software spoke current behavior is this:
> > * every time you switch to another environment, you selection is
> >   erased and replaced by defaults for the given spoke (if the
> >   current comps and environment that has any addons set as default)
> > * even if you previously selected an addon that is also available
> >   in the new environment, you selection will still be cleared
> > * defaults for the given environment will be always selected again
> >   when switching, even if you deselected them previously
> > 
> > The patch fixes these issues so that:
> > * once you select an addon, it will stay selected in all environments
> >   you switch into that include the given addon
> > * the same thing for deselecting defaults - once you deselect a default,
> >   it will be deselected in all environments that have it enabled by default
> > * of course once you click on "done" only the addons in the currently ticked
> >   environment will be used for the install
> > 
> > Also regarding the implementation, I've replaced the two lists (one of them
> > was for some reason not being used for anything) by dict and decoupled
> > user selection from getting list of currently selected addons in apply,
> > making it possible to remove quite a few lines of code. :)
> > 
> > Martin Kolman (1):
> >   Keep selection when switching environments
> > 
> >  pyanaconda/ui/gui/spokes/software.py | 43 +++++++++++++-----------------------
> >  1 file changed, 15 insertions(+), 28 deletions(-)
> Other than those few rather neatpicks this looks like a very nice change. ACK!
> 
Thanks! :) Fixing locally and (I guess) putting to freezer with a "7.1"
label.



More information about the anaconda-patches mailing list