[master] pylint: Clean up accordion warnings

Brian C. Lane bcl at redhat.com
Sat Mar 1 00:25:04 UTC 2014


Gtk.true() really does exist. And a new warning has been added for
calling a super-superclass instead of the immediate superclass.
---
 pyanaconda/ui/gui/spokes/lib/accordion.py | 4 ++--
 tests/pylint/pylint-false-positives       | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/lib/accordion.py b/pyanaconda/ui/gui/spokes/lib/accordion.py
index c1ec679..cc0aea9 100644
--- a/pyanaconda/ui/gui/spokes/lib/accordion.py
+++ b/pyanaconda/ui/gui/spokes/lib/accordion.py
@@ -235,7 +235,7 @@ class Page(Gtk.Box):
 class UnknownPage(Page):
     def __init__(self, title):
         # For this type of page, there's only one place to store members.
-        # pylint: disable=W0231
+        # pylint: disable=W0231,W0233
         Gtk.Box.__init__(self, orientation=Gtk.Orientation.VERTICAL, spacing=6)
         self.members = []
         self.pageTitle = title
@@ -260,7 +260,7 @@ class UnknownPage(Page):
 # is created, it will be removed and replaced with a Page for it.
 class CreateNewPage(Page):
     def __init__(self, title, createClickedCB, autopartTypeChangedCB, partitionsToReuse=True):
-        # pylint: disable=W0231
+        # pylint: disable=W0231,W0233
         Gtk.Box.__init__(self, orientation=Gtk.Orientation.VERTICAL, spacing=6)
         self.members = []
         self.pageTitle = title
diff --git a/tests/pylint/pylint-false-positives b/tests/pylint/pylint-false-positives
index cea7aa5..e2b0c09 100644
--- a/tests/pylint/pylint-false-positives
+++ b/tests/pylint/pylint-false-positives
@@ -67,6 +67,7 @@
 ^E1101:[ 0-9]*,[0-9]*:.*: Module '.*' has no 'parse_markup' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Module '.*' has no 'init' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Module '.*' has no 'bind' member$
+^E1101:[ 0-9]*,[0-9]*:.*: Module 'gi.repository.Gtk' has no 'true' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Class '.*' has no 'get_default' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Class '.*' has no 'add_provider_for_screen' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Class '.*' has no 'new_with_default_fallbacks' member$
-- 
1.8.5.3



More information about the anaconda-patches mailing list