[master][PATCH] Use the right index for selecting region (#1114234)

David Shea dshea at redhat.com
Mon Jun 30 21:48:48 UTC 2014


On 06/30/2014 05:16 PM, Chris Lumens wrote:
>>> diff --git a/pyanaconda/ui/tui/spokes/time_spoke.py b/pyanaconda/ui/tui/spokes/time_spoke.py
>>> index 62a1b23..3995a70 100644
>>> --- a/pyanaconda/ui/tui/spokes/time_spoke.py
>>> +++ b/pyanaconda/ui/tui/spokes/time_spoke.py
>>> @@ -104,7 +104,7 @@ class TimeZoneSpoke(FirstbootSpokeMixIn, NormalTUISpoke):
>>>                       self.apply()
>>>                       self.close()
>>>                   else:
>>> -                    self.app.switch_screen(self, self._regions[id])
>>> +                    self.app.switch_screen(self, self._regions[index])
>>>                   return INPUT_PROCESSED
>>>               elif key.lower() == "b":
>>>                   self.app.switch_screen(self, None)
>> This should have been caught by pylint, yeah?
> After poking around at this a little bit... no, not really.  I can make
> "id" a bad variable name which shows that we are using it in a couple
> places, but doesn't do anything for this case.  I can make "id" a bad
> builtin function to use but that doesn't catch this either.  So we would
> either have to write something for this (which I'm not especially
> inclined to do) or just keep an eye out.
>
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

Do you think it'd be something worth raising upstream? pylint doesn't 
have checks on list index operations, so maybe it could use some. Here's 
a quick dirty version as a pylint plugin: http://fpaste.org/114472/16488614/


More information about the anaconda-patches mailing list