[libblockdev 00/10] Some libblockdev fiddles

mulhern amulhern at redhat.com
Wed Jun 25 21:35:29 UTC 2014


The first four are things I stumbled across while trying to build w/out
warnings.

The last five are all about the Makefile. There's plenty more to do, but I'ld
like feedback before I go any further.

mulhern (10):
  Do not start using next_line until needed.
  Do not check for NULL value for ret
  Discard const modifier on ret
  Put const modifier on some things very heavily
  Add an initial .gitignore file.
  Use pattern rules to generate plugin boilerplate.
  Remove unnecessary header file from LIBRARY_FILES
  Start a clean target.
  Make build-library into a file target.
  Leave out link-time flags when compiling.

 .gitignore                   |  6 ++++++
 Makefile                     | 50 +++++++++++++++++++++++++-------------------
 src/lib/plugin_apis/common.h |  2 +-
 src/plugins/crypto.c         |  6 ++----
 src/plugins/lvm.c            |  4 ++--
 src/plugins/swap.c           |  7 +++----
 src/plugins/test_lvm.c       |  2 +-
 src/utils/sizes.c            |  2 +-
 8 files changed, 44 insertions(+), 35 deletions(-)
 create mode 100644 .gitignore

-- 
1.9.3



More information about the anaconda-patches mailing list