[anaconda][master][PATCH 0/3] Use bools for flags and replace some redundant ifs
Martin Kolman
mkolman at redhat.com
Thu Jun 19 07:24:18 UTC 2014
On Wed, 2014-06-18 at 16:59 -0700, Brian C. Lane wrote:
> On Wed, Jun 18, 2014 at 02:24:04PM +0200, Martin Kolman wrote:
> > Misc patches related to how we assign values to flags and the anaconda variables
> > from options. The main aim is to get rid of using integers in place of booleans and
> > to dump redundant ifs in favor of direct assignment.
> >
> > Martin Kolman (3):
> > Use True/False instead of 1/0 for flags
> > Replace ifs when assigning option values to flags where possible
> > Replace redundant ifs with direct assignments to the anaconda
> > variables
> >
> > anaconda | 61 +++++++++++++++++------------------------------------
> > pyanaconda/flags.py | 8 +++----
> > 2 files changed, 23 insertions(+), 46 deletions(-)
> >
> > --
> > 1.9.3
>
> Looks good to me. I was concerned that maybe there were some defaults
> that were only supposed to be overridden if the opts.* was set but I
> don't see anything like that.
I checked that the default & the default value returned by the given
option match, so it should be fine.
More information about the anaconda-patches
mailing list