[blivet:master 0/8] #1090009 related patches

mulhern amulhern at redhat.com
Wed Jun 18 19:05:07 UTC 2014


The first two are minor cleanups.
Omit special check...is a decision, I may be wrong there.
Rename devicetree_test...there was a lot more in which I tried to actually
construct some useful devicetree unit tests, but this is all that remains
(http://www.topatoco.com/merchant.mvc?Screen=PROD&Store_Code=TO&Product_Code=CG-TROPHY&Category_Code=WON). It's kind of optional at this point.
Factor out commonalities...busy, but not subtle.
Remove preferLeaves...the alternative is to have them all take preferLeaves,
and factor that out into a separate method, but from the commit messages
preferLeaves seems to have been pretty ad-hoc.
The two last are simple, and address half the problem in the bug, the problem
of discovering the array even if it is missing some devices. The other half,
what to do when the array is still unusable, has yet to be addressed, but
I'm hoping for some feedback, before I go farther.
Oh, and I can't actually test this on anaconda, due to some strangeness that
is causing the udev info to be fragmentary so that the name and the uuid of
the array device are both unobtainable and so lookup does not occur at all.
I've farmed the testing out to the original reporter.

There is an accompanying anaconda patch, coming right up.

mulhern (8):
  Move down or remove assignment to device in add* methods.
  Remove unused 'slaves' variable.
  Omit special check for md devices in addUdevDevice().
  Rename devicetree_test file to something somewhat more appropriate.
  Factor out commonalities among getDevice[s|]By* methods.
  Remove preferLeaves parameter from getDeviceByPath()
  Add a flag to control whether a raid array may be run when degraded
    (#1090009)
  When adding an md array, allow adding incomplete arrays (#1090009)

 blivet/devicetree.py          | 334 +++++++++++++++++-------------------------
 blivet/flags.py               |   2 +
 tests/devicetree_test.py      | 283 -----------------------------------
 tests/devicetreestate_test.py | 283 +++++++++++++++++++++++++++++++++++
 4 files changed, 416 insertions(+), 486 deletions(-)
 delete mode 100644 tests/devicetree_test.py
 create mode 100644 tests/devicetreestate_test.py

-- 
1.9.3



More information about the anaconda-patches mailing list