[rhel6-branch] Catch custom partitioning problems on UEFI (#991620)

Samantha N. Bueno sbueno+anaconda at redhat.com
Wed Jun 18 01:57:13 UTC 2014


Ack.

On Tue, Jun 17, 2014 at 10:43:19AM -0700, Brian C. Lane wrote:
> When installing over the top of a previous UEFI installation it would
> not check to see if the previous EFI System Partition had been assigned
> a mountpoint. The installation would proceed and then crash in the
> bootloader step.
> 
> Resolves: rhbz#991620
> ---
>  platform.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/platform.py b/platform.py
> index e866133..8338f44 100644
> --- a/platform.py
> +++ b/platform.py
> @@ -272,7 +272,7 @@ class EFI(Platform):
>              NOTE: X86 does not have a separate checkBootRequest method,
>                    so this one must work for x86 as well as EFI.
>          """
> -        if not req and self.isEfi:
> +        if self.isEfi and (not req or not req.format.mountpoint):
>              return [_("You have not created a /boot/efi partition.")]
>          elif not req:
>              return [_("You have not created a bootable partition.")]
> @@ -292,6 +292,9 @@ class EFI(Platform):
>              boot_errors = Platform.checkBootRequest(self, boot_device)
>              errors += boot_errors
>  
> +        if not boot_device:
> +            return errors
> +
>          # Limit /boot to 2TB
>          if boot_device.size > 2*1024*1024:
>              # If there is no /boot, ask for one
> -- 
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list