[PATCH 1/2] Improve the SpokeSelector icon error reporting.

David Shea dshea at redhat.com
Fri Jun 13 19:22:58 UTC 2014


On 06/13/2014 01:31 PM, David Shea wrote:
>       pixbuf = gtk_icon_info_load_icon(icon_info, NULL);
> +    g_object_unref(icon_info);
> +
> +    if (NULL == pixbuf) {
> +        fprintf(stderr, "could not load icon: %s\n", err->message);
> +        g_error_free(err);
> +        return;
> +    }

Actually that error check would segfault if it ever got used, because 
err is always NULL. Whoops! Replace the NULL second parameter to 
gtk_icon_info_load_icon with &err.


More information about the anaconda-patches mailing list