[master][PATCH] Don't install implicitly added but explicitly excluded packages (#1105013)

Brian C. Lane bcl at redhat.com
Thu Jun 5 14:35:48 UTC 2014


On Thu, Jun 05, 2014 at 12:56:29PM +0200, Vratislav Podzimek wrote:
> Users are responsible for package selection in case they explicitly excluded one
> of storage/bootloader-required packages.
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> ---
>  pyanaconda/install.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/pyanaconda/install.py b/pyanaconda/install.py
> index 2bdbbd1..050c832 100644
> --- a/pyanaconda/install.py
> +++ b/pyanaconda/install.py
> @@ -197,8 +197,10 @@ def doInstall(storage, payload, ksdata, instClass):
>      if not ksdata.bootloader.disabled:
>          packages += storage.bootloader.packages
>  
> -    # don't try to install packages from the install class' ignored list
> -    packages = [p for p in packages if p not in instClass.ignoredPackages]
> +    # don't try to install packages from the install class' ignored list and the
> +    # explicitly excluded ones (user takes the responsibility)
> +    packages = [p for p in packages
> +                if p not in instClass.ignoredPackages and p not in ksdata.packages.excludedList]
>      payload.preInstall(packages=packages, groups=payload.languageGroups())
>      payload.install()
>  
> -- 
> 1.9.3

When this inevitably leads to someone excluding something we actually
use are the errors going to be clear enough that they won't file a bug?

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list