[master 2/2] Use exec instead of system to run metacity

Vratislav Podzimek vpodzime at redhat.com
Thu Jul 31 09:11:40 UTC 2014


On Wed, 2014-07-30 at 17:00 -0400, David Shea wrote:
> This way we don't up with a second process named "anaconda" that's
> actually a middleman for the window manager.
> ---
>  anaconda | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/anaconda b/anaconda
> index 4d4676e..6ff4a89 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -269,14 +269,13 @@ def startMetacityWM():
>          # after this point the method should never return (or throw an exception
>          # outside)
>          try:
> -            returncode = iutil.execWithRedirect('metacity', ["--display", ":1", "--sm-disable"])
> -        except BaseException as e:
> +            os.execlp("metacity", "metacity", "--display", ":1", "--sm-disable")
> +        except BaseException:
I know you didn't come up with with it, but do we really need to catch
all BaseException-inherited exceptions here? I mean, it shouldn't throw
an expception outside, but if it raises anything else from OSError, it's
a bug we should fix, right? I'm probably thinking too much in the
context of the recent "at the edge with RAM" context, but I've seen
various failures we hide in case something like ENOMEM starts happening.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list