[anaconda][master] Fix issues reported by pyflakes

David Shea dshea at redhat.com
Wed Jul 30 13:36:02 UTC 2014


On 07/30/2014 04:33 AM, Vratislav Podzimek wrote:
> diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
> index 6364f54..bbbdb9c 100644
> --- a/pyanaconda/ui/gui/__init__.py
> +++ b/pyanaconda/ui/gui/__init__.py
> @@ -615,6 +615,7 @@ class GraphicalUserInterface(UserInterface):
>               dlg.refresh(details)
>               rc = dlg.run()
>               dlg.window.destroy()
> +            return rc
>   
>       @gtk_action_wait
>       def showYesNoQuestion(self, message):

For this one, we still don't really care about the return value, so I'd 
rather that dlg.run() just not be assigned to anything to make it 
consistent with showError a couple lines up.

Other than that, looks good.


More information about the anaconda-patches mailing list