[PATCH 1/2] Move sanityCheck code to anaconda's codebase

Vratislav Podzimek vpodzime at redhat.com
Wed Jul 30 09:04:13 UTC 2014


On Wed, 2014-07-30 at 04:38 -0400, Anne Mulhern wrote:

> 
> It looks like you're being inconsistant w/ LUKSDeviceWithoutKeyError,
> since you import it from blivet but also define it in anaconda.
> 
> I think you're better off just moving it and blivet._verifyLUKSDevicesHaveKey()
> method into anaconda, preserving its place in the class hierarchy.
> That way, the bits of code that assign to various lists based on type of error
> will still do the right thing.
Good point. I think moving verifyLUKSDevicesHaveKey to Anaconda would be
the best solution.

I'll send a follow-up patch soon.

Thanks!

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list