[blivet:master 00/14] Miscellaneous mostly RAID patches (v2)
David Lehman
dlehman at redhat.com
Fri Jul 18 14:15:52 UTC 2014
On 07/16/2014 11:56 AM, mulhern wrote:
> More things I ran into while looking at the things from review.
> New or substantially changed patches are:
> * Remove all references to mdMinor...
> * Remove DeviceFormat.probe() ...
> * Be more robust...
> * Extend mdadm()...
> * Add a method to extract...
> and all following except Split mdadd() into two...
>
> I'm only sending the changed ones.
>
> mulhern (14):
> Make docstring more precise.
> Remove commented out import.
> Use super() instead of explicit parent name
> Generalize the error message for the array level
> Remove all references to mdMinor in current code base.
> Remove DeviceFormat.probe() method
> Add a docstring to mdraid.mdexamine
> Factor canonicalizeUUID() into separate method.
> Be more robust in the face of possible changes to mdadm's UUIDs.
> Extend mdadm() to capture output in the same way as btrfs()
> Add a method to extract information about an mdraid array
> Refactor mdraid tests.
> Change mdadm() so that it raises an exception when the command fails
> Split mdadd into separate functions.
>
> blivet/devicelibs/mdraid.py | 134 ++++++++++---
> blivet/devices.py | 6 +-
> blivet/fcoe.py | 1 -
> blivet/formats/__init__.py | 4 -
> blivet/formats/luks.py | 7 -
> blivet/formats/lvmpv.py | 11 --
> blivet/formats/mdraid.py | 15 --
> blivet/udev.py | 4 +-
> tests/devicelibs_test/mdraid_interrogate_test.py | 236 +++++++++++++++++++++++
> tests/devicelibs_test/mdraid_test.py | 169 +++++++---------
> 10 files changed, 423 insertions(+), 164 deletions(-)
> create mode 100755 tests/devicelibs_test/mdraid_interrogate_test.py
>
These look good to me.
David
More information about the anaconda-patches
mailing list