[PATCH rhel6-branch] Increment MD container child counter even if its volumes are ignored (#1120640)

David Lehman dlehman at redhat.com
Fri Jul 18 12:50:01 UTC 2014


On 07/18/2014 03:21 AM, Artur Paszkiewicz wrote:
> On 07/18/2014 09:49 AM, Vratislav Podzimek wrote:
>> On Fri, 2014-07-18 at 09:32 +0200, Artur Paszkiewicz wrote:
>>> On 07/17/2014 05:30 PM, David Lehman wrote:
>>>> On 07/17/2014 06:39 AM, Artur Paszkiewicz wrote:
>>>>> Volumes which are not selected in Specialized Storage Devices are
>>>>> ignored in addUdevDevice. This causes that their parent container
>>>>> won't have its child counter incremented, which can later cause an
>>>>> incorrect unusedRaidMembersWarning.
>>>>
>>>> Why would you not select all members/components of a container you plan to use?
>>>
>>> I may not want to use some particular container for installation. There
>>> can be multiple containers on different disks. This results in a
>>> misleading warning, that "disks contain BIOS RAID metadata, but are not
>>> part of any recognized BIOS RAID sets". This is not true - the RAID
>>> arrays are assembled and recognized, just not selected in the installer.
>> But only if you select some devices from the container for installation,
>> right? That's seems like a situation dangerous enough to show a warning
>> even if a bit misleading.
>
> No, this happens when I don't select any devices (BIOS RAID sets) from
> the container. I can't see why this could be dangerous. I'm not
> selecting any of the component disks of the container, in fact they are

But what if you were selecting one of them? This patch would disable a 
valid warning.

My take is that we shouldn't be showing a warning about a fwraid array 
on unselected disks. Rather than lie about what we've found, we should 
be more careful about what conditions we warn under.

David

> not even shown on any of the tabs, so they must be properly identified
> as RAID component devices. Here are the steps to reproduce this:
>
> 1. Create 2 IMSM RAID arrays on different disks
> 2. Run the RHEL installer
> 3. Select "Specialized Storage Devices"
> 4. On the "Firmware RAID" tab select only one RAID array and click
> "Next"
>
> Artur
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>



More information about the anaconda-patches mailing list