[blivet:master 11/14] Add a method to extract information about an mdraid array

Vratislav Podzimek vpodzime at redhat.com
Thu Jul 17 14:27:52 UTC 2014


On Wed, 2014-07-16 at 12:56 -0400, mulhern wrote:
> mdadm --detail can give useful information about the number of spare devices
> and other things that mdadm --examine can not. According to the man page
> --examine applies to devices which are components of an array, while --detail
> applies to a whole array which is currently active.
> 
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>  blivet/devicelibs/mdraid.py | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/blivet/devicelibs/mdraid.py b/blivet/devicelibs/mdraid.py
> index 2f0ac86..83f87cf 100644
> --- a/blivet/devicelibs/mdraid.py
> +++ b/blivet/devicelibs/mdraid.py
> @@ -21,6 +21,7 @@
>  #
>  
>  import os
> +import re
>  import uuid
>  
>  from .. import util
> @@ -286,6 +287,38 @@ def mdexamine(device):
>  
>      return info
>  
> +def mddetail(device):
> +    """Run mdadm --detail in order to read information about an array.
> +
> +       Note: The --export flag is not used. According to the man pages
> +       the export flag just formats the output as key=value pairs for
> +       easy import, but in the case of --detail it also omits the majority
> +       of the information, including information of real use like the
> +       number of spares in the array.
> +
> +       :param str device: path of the array device
> +       :rtype: a dict of strings
> +       :returns: a dict containing labels and values extracted from output
> +    """
> +    lines = mdadm(["--detail", device], capture=True).split("\n")
> +    info = {}
> +    for (name, colon, value) in (line.strip().partition(":") for line in lines):
> +        value = value.strip()
> +        name = name.strip().upper()
> +        if colon and value and name:
> +            info[name] = value
> +
> +    for k, v in ((k,info[k]) for k in ('UUID',) if k in info):
I know this is a copy-paste from a different place, but by removing the
second thing from the tuple it became quite weird, overly complex and
cryptic.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list