[blivet:master 0/8] Miscellaneous mostly RAID patches
Brian C. Lane
bcl at redhat.com
Tue Jul 15 22:50:27 UTC 2014
On Tue, Jul 15, 2014 at 05:34:59PM -0400, mulhern wrote:
> Some things I ran into while trying (and failing) to achieve much greater
> things.
>
> The first six are utterly trivial. Of the remaining three...
>
> * Add a method...
> The method mddetail is not actually used in blivet now, but I think it
> has potential. Obviously I had a plan for using it.
> * Refactor mdraid tests
> It was the smart thing to do, and very informative about mdadm's operation,
> which lead to:
> * Split mdadd into separate functions...
> I would like this change to be part of the specification of the libblockdev
> plugin.
>
> mulhern (8):
> Make docstring more precise.
> Remove commented out import.
> Factor canonicalizeUUID() into separate method.
> Use super() instead of explicit parent name
> Generalize the error message for the array level
> Add a method to extract information about an mdraid array
> Refactor mdraid tests.
> Split mdadd into separate functions.
>
> blivet/devicelibs/mdraid.py | 85 +++++++--
> blivet/devices.py | 6 +-
> blivet/fcoe.py | 1 -
> blivet/udev.py | 4 +-
> tests/devicelibs_test/mdraid_interrogate_test.py | 220 +++++++++++++++++++++++
> tests/devicelibs_test/mdraid_test.py | 169 ++++++++---------
> 6 files changed, 365 insertions(+), 120 deletions(-)
> create mode 100755 tests/devicelibs_test/mdraid_interrogate_test.py
>
> --
> 1.9.3
These look good to me, other than my 2 comments.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
More information about the anaconda-patches
mailing list