[blivet] small patches for partitioning
Vratislav Podzimek
vpodzime at redhat.com
Thu Jul 10 06:08:35 UTC 2014
On Wed, 2014-07-09 at 13:08 -0500, David Lehman wrote:
> Patch 1 means that kickstart with multiple growable requests could end
> up with some unusable results due to all requests thinking they're
> entitled to 0% of the free sectors in the chunk/disk. Float would probably
> suffice since it's only calculating a percentage, but using Decimal has
> become a habit.
>
> Patches 2 and 3 are minor bugs I noticed when doing some other work.
>
> Patch 4 has been sitting on the shelf for a couple of months for no real
> reason.
>
> David Lehman (4):
> Don't use integer division to calculate a fraction.
> A Chunk is done growing when its pool is empty.
> Honor the skip list when allocating leftover sectors.
> Add some tests for Chunk and Request class hierarchy.
>
> blivet/partitioning.py | 7 ++-
> tests/partitioning_test.py | 138 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 142 insertions(+), 3 deletions(-)
These all look good to me and I like the PATCH 4/4 in particular. ACK!
--
Vratislav Podzimek
Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list