[blivet:master 0/2] Removing udev_ prefix from udev methods patches

Martin Kolman mkolman at redhat.com
Tue Jul 8 10:27:30 UTC 2014


On Mon, 2014-07-07 at 18:15 -0400, mulhern wrote:
> The only reason to import udev in blivet.formats.__init__.py is for the
> methods that are removed in "Remove all references". Importing udev,
> rather than names from udev, causes
> pylint errors that cannot be dismissed with the disable= annotations.
> Trying to figure out what was going on caused me to notice that these methods
> should probably just go away. I still dunno what was up w/ pylint.
> 
> mulhern (2):
>   Remove all references to DeviceFormat.majorminor
>   Remove udev_ prefix from udev methods.
> 
>  blivet/__init__.py          |   2 +-
>  blivet/deviceaction.py      |  10 +-
>  blivet/devices.py           |  57 +++++----
>  blivet/devicetree.py        | 298 ++++++++++++++++++++++----------------------
>  blivet/fcoe.py              |   4 +-
>  blivet/formats/__init__.py  |  44 -------
>  blivet/formats/disklabel.py |   4 +-
>  blivet/formats/fs.py        |   4 +-
>  blivet/iscsi.py             |   4 +-
>  blivet/udev.py              | 274 ++++++++++++++++++++--------------------
>  blivet/zfcp.py              |   8 +-
>  tests/devicetree_test.py    |   4 +-
>  tests/udev_test.py          |  36 +++---
>  13 files changed, 352 insertions(+), 397 deletions(-)
> 
Both of these look good to me.



More information about the anaconda-patches mailing list