[anaconda][master][PATCH] No jumping in progress spoke!

Vratislav Podzimek vpodzime at redhat.com
Mon Jul 7 09:40:27 UTC 2014


On Fri, 2014-07-04 at 16:34 +0200, Martin Kolman wrote:
> I have been checking out how the new stacked window Anaconda works
> (very well! :)) and noticed that when the "we won't touch your other disks"
> labels are hidden or shown they make the other widgets jump around.
> 
> While discussing how to solve this on IRC, Halfline advised to use the
> GtkRevealer widget, which was introduced in GTK 3.10. Turns out Revealer
> works very well and fixes the issue, so thanks a lot Halfline! :)
> 
> I think there might be quite a lot of other places where we could
> use this widget - not only to prevent "jumping" but also to improve
> graphical interface feedback as Revealer support various hide/show transitions
> that could make stuff showing up/vanishing less visually jarring.
> 
> Martin Kolman (1):
>   Use GtkRevealer for widget hiding in storage spoke
> 
>  pyanaconda/ui/gui/spokes/storage.glade | 125 ++++++++++++++++++++-------------
>  pyanaconda/ui/gui/spokes/storage.py    |  10 +--
>  2 files changed, 80 insertions(+), 55 deletions(-)
The patch looks good to me and the difference is really big and nice!

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list