[PATCH 00/10+1] single window GUI, take 2

Vratislav Podzimek vpodzime at redhat.com
Wed Jul 2 13:22:32 UTC 2014


On Mon, 2014-06-30 at 15:41 -0400, David Shea wrote:
> Changes since last time:
>   - Fixed the stuff that Vratislav pointed out:
>     * Added a macro for the sidebar width percentage
>     * Changed finalize to dispose since that's more in the spirit of reference
>       releases
>     * Fixed a couple of comments
>     * Changed Spoke._visitedSinceApplied to a public property
>     * Added MainWindow to ANACONDA_WINDOW_GROUP. Added the exception window to
>       it, too, since there is no longer a separate Gtk.main loop for spokes and
>       no separate spoke window to get stuck under.
> 
>   - Fixed makeupdates to work with the widgets version increase
> 
>   - Increased the version of the .gir and .typelib files too since that seems
>     like the thing to do
> 
>   - Replaced the lightbox with something hopefully less fragile
> 
>   - Removed the resize on realize part from MainWindow since it turns out it
>     didn't actually work
> 
>   - Updated initial-setup for the new HubWindow
> 
>   - Added a couple more deprecation warning ignores since I apparently I missed
>     some last time
> 
> David Shea (10):
>   Add a couple more deprecation warning ignores
>   Remove the custom accelerators from custom storage.
>   Use globs for the anaconda widgets library paths
>   Increased the version of anaconda-widgets to 3.0
>   Add a class BaseStandalone.
>   Add a window to manage Anaconda screen transitions.
>   Add a delete-event handler for the main window
>   Added a method to create new GdkPixbufs from in-memory data
>   Implement the lightbox in MainWindow
>   Remove the Lightbox widget
> 
>  po/POTFILES.in                                     |   2 +-
>  pyanaconda/ui/common.py                            |   2 +-
>  pyanaconda/ui/gui/__init__.py                      | 212 ++++++++++--
>  pyanaconda/ui/gui/hubs/__init__.py                 |  91 ++---
>  pyanaconda/ui/gui/hubs/progress.glade              |   5 +-
>  pyanaconda/ui/gui/hubs/progress.py                 |  11 +-
>  pyanaconda/ui/gui/hubs/summary.glade               |   6 +-
>  pyanaconda/ui/gui/hubs/summary.py                  |   7 -
>  pyanaconda/ui/gui/spokes/__init__.py               |  19 +-
>  pyanaconda/ui/gui/spokes/custom.glade              |   3 +-
>  pyanaconda/ui/gui/spokes/custom.py                 |  24 +-
>  pyanaconda/ui/gui/spokes/datetime_spoke.py         |   4 +-
>  pyanaconda/ui/gui/spokes/filter.py                 |   7 +-
>  pyanaconda/ui/gui/spokes/keyboard.py               |   8 +-
>  .../ui/gui/spokes/lib/custom_storage_helpers.glade |   1 -
>  pyanaconda/ui/gui/spokes/network.py                |   8 +-
>  pyanaconda/ui/gui/spokes/software.py               |   4 +-
>  pyanaconda/ui/gui/spokes/source.py                 |  10 +-
>  pyanaconda/ui/gui/spokes/storage.py                |   8 +-
>  pyanaconda/ui/gui/spokes/user.py                   |   3 +-
>  pyanaconda/ui/gui/spokes/welcome.py                |  10 +-
>  pyanaconda/ui/gui/tools/run-spoke.py               |   7 +-
>  pyanaconda/ui/gui/utils.py                         |  15 +-
>  scripts/makeupdates                                |  12 +-
>  widgets/configure.ac                               |   2 +-
>  widgets/doc/AnacondaWidgets-docs.xml               |   2 +-
>  widgets/glade/AnacondaWidgets.xml                  |  13 +-
>  widgets/src/BaseStandalone.c                       | 377 +++++++++++++++++++++
>  widgets/src/BaseStandalone.h                       |  81 +++++
>  widgets/src/BaseWindow.c                           |  14 +-
>  widgets/src/BaseWindow.h                           |   6 +-
>  widgets/src/HubWindow.c                            |  94 +----
>  widgets/src/HubWindow.h                            |   6 +-
>  widgets/src/LayoutIndicator.c                      |   2 +
>  widgets/src/Lightbox.c                             | 360 --------------------
>  widgets/src/Lightbox.h                             |  67 ----
>  widgets/src/Makefile.am                            |  20 +-
>  widgets/src/SpokeWindow.c                          |  29 +-
>  widgets/src/StandaloneWindow.c                     | 242 +++----------
>  widgets/src/StandaloneWindow.h                     |  15 +-
>  widgets/src/widgets-common.c                       |  51 ++-
>  widgets/src/widgets-common.h                       |   3 +
>  42 files changed, 893 insertions(+), 970 deletions(-)
>  create mode 100644 widgets/src/BaseStandalone.c
>  create mode 100644 widgets/src/BaseStandalone.h
>  delete mode 100644 widgets/src/Lightbox.c
>  delete mode 100644 widgets/src/Lightbox.h
These all look good to me with that one minor comment on PATCH 05/10.
Thanks for applying all the suggestions.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list