[pungi] Don't emit media labels with spaces in them.

Vratislav Podzimek vpodzime at redhat.com
Tue Jul 1 05:48:58 UTC 2014


On Mon, 2014-06-30 at 16:44 -0400, Peter Jones wrote:
> Spaces cause various bugs like #923374 and #855849 , and it would be
> better if we just didn't use them.
> 
> Note that there's a corresponding lorax change to go with this.
> 
> Signed-off-by: Peter Jones <pjones at redhat.com>
> ---
>  src/pypungi/__init__.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pypungi/__init__.py b/src/pypungi/__init__.py
> index 9e9d161..6c65bc9 100644
> --- a/src/pypungi/__init__.py
> +++ b/src/pypungi/__init__.py
> @@ -1608,7 +1608,7 @@ class Pungi(pypungi.PungiBase):
>          # NOTE: if this doesn't match what's in the bootloader config, the
>          # image won't be bootable!
>          extraargs.append('-V')
> -        extraargs.append('%s %s %s' % (self.config.get('pungi', 'name'),
> +        extraargs.append('%s-%s-%s' % (self.config.get('pungi', 'name'),
>              self.config.get('pungi', 'version'), self.tree_arch))
>  
>          extraargs.extend(['-o', isofile])
I like this neat solution. ACK.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list