[PATCH] Another cut at better stage1 bootloader errors

Adam Williamson awilliam at redhat.com
Fri Jan 31 02:34:55 UTC 2014


So this time I defined a new property for the error message (so we're not
reading an internal attribute), made the UEFI error message state that the
ESP must be on GPT (as we've decided we're not going to allow it to be on
MBR after all), added error messages for all the other platforms based on
the constraints as expressed in platform.py, and tweaked the generic error
a bit more.

The second patch makes the stage2 missing error not show if stage1 is also
missing. I think stage2 will never be set if stage1 is missing, even if
there actually is a valid stage2 device - I've been testing this by creating
a layout for a UEFI install with a /boot, a swap, and a /, but no ESP. Without
this second patch, you see the "You have not created a bootable partition."
error, even though you have. I tested, and this patch seems to do the trick:
if I create a /boot partition but no ESP, I just get the generic and platform-
specific stage1 missing errors; if I create an ESP but no /boot or / partition,
I see the missing stage2 error - "You have not created a bootable partition." -
but no missing stage1 error. (And, of course, if I do everything right, no
errors and install can proceed: I did think to check that too :>)



More information about the anaconda-patches mailing list