[PATCH] Provide a mechanism for platform-specific error messages for stage1 failure

Adam Williamson awilliam at redhat.com
Tue Jan 28 06:58:57 UTC 2014


On Tue, 2014-01-28 at 07:56 +0100, Vratislav Podzimek wrote:

> I think it should be "missing_errors" as it is the list of errors. Other
> than that this looks like a nice idea to me and the patch looks okay.
> I'll let the other guys check it and I'll push it tomorrow unless there
> are any objections. Thanks for the patch!

BLUE, damnit, the bike shed is BLUE =)

I chose the singular from the point of view of the platform: the
platform defines a singular "error" to be displayed when stage1
selection fails. This singular "error" is then pulled into a plural list
of "errors" by sanityCheck(), sure, but from the point of view of the
bit of code that actually *defines* the "error", there is exactly one of
it.

Strictly speaking I suppose it could be missing_error_message, but boy,
all that typing.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net



More information about the anaconda-patches mailing list