[anaconda:rhel7/master 0/3] Small labeling patches

Vratislav Podzimek vpodzime at redhat.com
Thu Jan 23 05:39:50 UTC 2014


On Wed, 2014-01-22 at 15:33 -0500, mulhern wrote:
> All sort of important.
> 
> Make label field...I had failed to realize that if the file format is changed,
> whether or not it exists might possibly change to. In the spirit of not changing
> the label fields sensitivity constantly with every change to the reformat box or
> filesystem fields, which can lead to awkward dead ends without actually
> ensuring correctness, I had to settle for the one thing which holds true
> for all filesystem formats, which unfortunately appears to be just True.
> 
> Always reject label...I could not come up with a sequence of changes to file
> formats and labels that would make this wrong.
> 
> Use validate_label...this is pretty non-dangerous, it will just fail to write
> the change in more cases where it shouldn't be written anyway.
> 
> mulhern (3):
>   Make label field always sensitive (#1038590)
>   Always reject label if the format exists (#1038590)
>   Use validate_label to check whether label should be updated (#1038590)
> 
>  pyanaconda/ui/gui/spokes/custom.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
These all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list