[PATCH] Handle inst.{gpt,dnf,extlinux} using cmdline.getbool()

Will Woods wwoods at redhat.com
Tue Jan 21 18:33:04 UTC 2014


On Fri, 2014-01-17 at 11:59 +0100, Martin Kolman wrote:
> On Thu, 2014-01-16 at 18:42 -0500, Will Woods wrote:
> > It's good to use cmdline.getbool() for boolean boot args, because
> > e.g. 'dnf=0' should not enable dnf.
> > 
> > The behavior for these arguments doesn't change, except in the last two
> > cases listed in the table below:
> > 
> > Argument            Old result      New result
> > -                   disabled¹       disabled¹
> > nogpt               disabled¹       disabled
> > gpt                 enabled         enabled
> > gpt=[1|on|true]     enabled         enabled
> > gpt=[0|off|false]   enabled         disabled
> > gpt=1 nogpt         enabled         disabled
> > ¹ the flag is left unchanged here, but 'disabled' is the default value
> Looks good, ACK!
> 
> Also I'll just add that since 4bc881147317967a9fab786c3b6c1ca0ae345ec1,
> those flags should also work correctly with the "inst." prefix.

I left that out of the commit message for the sake of brevity, but
you're absolutely right.

-w



More information about the anaconda-patches mailing list