[PATCH 1/4] Make the device name in a MountpointSelector less wide (#1048583).

Vratislav Podzimek vpodzime at redhat.com
Mon Jan 20 11:49:27 UTC 2014


On Fri, 2014-01-17 at 13:53 -0500, Chris Lumens wrote:
> The name could be very long, obscuring the size of the device and making the
> accordion hard to use.
> ---
>  pyanaconda/ui/gui/spokes/lib/accordion.py | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/lib/accordion.py b/pyanaconda/ui/gui/spokes/lib/accordion.py
> index 39f7043..7366b32 100644
> --- a/pyanaconda/ui/gui/spokes/lib/accordion.py
> +++ b/pyanaconda/ui/gui/spokes/lib/accordion.py
> @@ -58,11 +58,16 @@ def selectorFromDevice(device, selector=None, mountpoint=""):
>      else:
>          mp = _("Unknown")
>  
> +    if len(device.name) > 25:
> +        name = device.name[0:12] + "..." + device.name[-12:]
> +    else:
> +        name = device.name
> +
>      if not selector:
> -        selector = MountpointSelector(device.name, str(device.size), mp)
> +        selector = MountpointSelector(name, str(device.size), mp)
>          selector._root = None
>      else:
> -        selector.props.name = device.name
> +        selector.props.name = name
>          selector.props.size = str(device.size)
>          selector.props.mountpoint = mp
I believe this should be done via Pango ellipsize. Any reason for not
using it?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list