[firstboot][PATCH] Exit the main process correctly even if reboot is required

Chris Lumens clumens at redhat.com
Fri Jan 10 19:41:20 UTC 2014


> @@ -447,11 +455,16 @@ class Interface(object):
>             method does not exit until the UI is unloaded.  From this point on,
>             all interaction must take place in callbacks.
>          """
> +
> +        global reboot_required
> +
>          self.displayModule()
>          self.win.present()
>          self.nextButton.grab_focus()
>          gtk.main()
>  
> +        return reboot_required
> +
>      def takeScreenshot(self):
>          """Take a screenshot."""
>          if not os.access(self._screenshotDir, os.R_OK):

I think you only need "global" if you are assigning to the variable.
Otherwise, this looks fine.

- Chris


More information about the anaconda-patches mailing list