[PATCH] dracut: minor shell cleanup

Chris Lumens clumens at redhat.com
Fri Jan 10 18:56:55 UTC 2014


> getargbool doesn't echo any result, so $(getargbool ...) will always
> evaluate to the empty string (""). This works fine in this case:
> 
>     if $(getargbool ...); then ...
> 
> because the 'if' statement uses the *return* value of the command, not its
> output. But if getargbool echoed a result (like getarg), this would
> break. So remove the subshell escape.

Looks fine.

- Chris


More information about the anaconda-patches mailing list