[master] Test that pango markup is correct and used correctly

Vratislav Podzimek vpodzime at redhat.com
Fri Jan 10 08:12:27 UTC 2014


On Thu, 2014-01-09 at 13:31 -0500, David Shea wrote:
> This is mostly an excuse to check the validity of the translations of pango
> markup, since some of those strings have some problems.
> 
> Two tests, since strings come from two sources: for the strings in python,
> there's a pylint module, and for the strings in glade there a new script. Both
> tests check that the markup is parseable and matches what pango says we can use
> and (if requested) that translated strings contain the same elements and
> attributes as the original string. The pylint module additionally checks that
> when markup is used as the left side of a format operation (e.g.,
> "<b>markup</b> string" % params), that the parameters are all escaped.  This
> might raise some annoying warnings since it only works if the escape happens in
> that expression and not five lines up or whatever, but we don't use markup like
> that much anyway, so it shouldn't be so bad.
Nice patch set! Apart from the rather stylistic comments these all look
good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list