[PATCH] Add a sidebar to the standalone windows (#1045250)

Brian C. Lane bcl at redhat.com
Thu Jan 9 01:30:45 UTC 2014


On Fri, Jan 03, 2014 at 01:52:57PM -0500, Máirín Duffy wrote:
> +static int get_sidebar_width(GtkWidget *window) {
> +	GtkAllocation allocation;
> +	/* change value below to make sidebar bigger / smaller */
> +	float sidebar_width_percentage = .18;  

Should use 0.18 so it is easier to read, also watch out for trailing
spaces.

Also style related, 4 spaces not tabs, please.

And follow the commenting style of the other functions, I think gobject
picks up on parts of it, clumens would know exactly what is needed
there.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list