[blivet:rhel7/master 0/5] Changes to the handling of filesystem labeling

Brian C. Lane bcl at redhat.com
Thu Jan 9 01:11:53 UTC 2014


On Sat, Dec 21, 2013 at 01:19:57PM -0500, mulhern wrote:
> The first three patches listed have all been reviewed and I've made all the
> suggested changes, so I'm not including them with the email.
> 
> The fourth is probably non-controversial, but should be checked.
> The fifth is possibly controversial, but short.
> 
> mulhern (5):
>   Changes to the handling of filesystem labeling (#1038590)
>   Remove fsConfigFromFile (#1038590)
>   More tests to check writing and reading labels (#1038590)
>   Restore ability to write an empty label where possible (#1038590)
>   Only allow label to be set if there is a labelling application
>     (#1038590)
> 
>  blivet/formats/fs.py            | 185 ++++++++++++++++------------
>  blivet/formats/fslabel.py       | 264 ++++++++++++++++++++++++++++++++++++++++
>  tests/formats_test/misc_test.py | 189 +++++++++++++++++++++++++---
>  3 files changed, 541 insertions(+), 97 deletions(-)
>  create mode 100644 blivet/formats/fslabel.py

These look good to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list