[PATCH 2/6] Prefer binary prefixes since everything is really based on them.

David Lehman dlehman at redhat.com
Wed Jan 8 15:20:49 UTC 2014


On Wed, 2014-01-08 at 09:10 -0500, Anne Mulhern wrote:
> 
> 
> 
> ----- Original Message -----
> > From: "David Lehman" <dlehman at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Tuesday, January 7, 2014 6:50:57 PM
> > Subject: [PATCH 2/6] Prefer binary prefixes since everything is really based	on them.
> > 
> > ---
> >  blivet/size.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/blivet/size.py b/blivet/size.py
> > index adc5f58..aaa3062 100644
> > --- a/blivet/size.py
> > +++ b/blivet/size.py
> > @@ -50,8 +50,8 @@ _binaryPrefix = [(1024, N_("kibi"), N_("Ki")),
> >                   (1024**7, N_("zebi"), N_("Zi")),
> >                   (1024**8, N_("yobi"), N_("Yi"))]
> >  
> > -_bytes = [N_('b'), N_('byte'), N_('bytes')]
> > -_prefixes = _decimalPrefix + _binaryPrefix
> > +_bytes = [N_('B'), N_('b'), N_('byte'), N_('bytes')]
> > +_prefixes = _binaryPrefix + _decimalPrefix
> >  
> >  def _makeSpecs(prefix, abbr, xlate):
> >      """ Internal method used to generate a list of specifiers. """
> > --
> 
> With this change the humanReadable tests not only changes its units indicator but also its numeric value,
> because MB now means megabytes not mebibytes.

Right. The corresponding change to the unit tests ended up in patch 6
instead of here.

> 
> - mulhern
> 
> > 1.8.1.4
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list