[blivet:rhel7/master 0/2] Supplement storage log ids

David Lehman dlehman at redhat.com
Tue Jan 7 17:03:08 UTC 2014


On Mon, 2014-01-06 at 16:16 -0500, mulhern wrote:
> These two both address a problem where the ids recorded in the storage log
> may not turn out to be so useful for debugging.

This is already being done for Device and DeviceAction. Your method is a
bit nicer, though. How about you convert Device and DeviceAction to also
use your class, but change the attribute name from 'object_id' to 'id'
to remain compatible with existing code?

David

> 
> While it does not resolve the issue I expect it will make subsequent similar 
> issues easier to address.
> 
> mulhern (2):
>   Make a class that creates a unique-per-class id for objects (#1043763)
>   Give DeviceFormat objects an object_id (#1043763)
> 
>  blivet/formats/__init__.py      | 11 +++++++----
>  blivet/util.py                  | 18 ++++++++++++++++++
>  tests/formats_test/init_test.py |  5 +++++
>  3 files changed, 30 insertions(+), 4 deletions(-)
> 




More information about the anaconda-patches mailing list