[PATCH] Add a sidebar to the standalone windows (#1045250)
David Shea
dshea at redhat.com
Mon Jan 6 20:09:25 UTC 2014
On 01/06/2014 02:59 PM, Máirín Duffy wrote:
> Hi David,
>
> On Mon, Jan 6, 2014 at 1:43 PM, David Shea <dshea at redhat.com> wrote:
>> What about right-to-left languages? Should the sidebar be on the
>> other side?
>>
> Gosh, that's a good question. I don't know how we handled this in old
> school firstboot (where we also had a sidebar like this.)
>
> I think that, if the button order changes for R-to-L (which I'm pretty
> sure it does) then the sidebar should move to the other side too. I
> can easily modify this so it can do either placement, but I'm not sure
> where to grab, logically, whether or not to draw it left or right
> from. :-/ Do you have any ideas?
There's a function in MountpointSelector.c, get_default_widget_direction
that copies the Gtk logic but allows it to be run after program startup.
We can move that to widgets-common.c and use it in the spokes and hubs.
More information about the anaconda-patches
mailing list