[anaconda/blivet][master/rhel7-branch] DASD storage re-write, take II

Jan Stodola jstodola at redhat.com
Wed Feb 26 09:20:10 UTC 2014


On 02/25/2014 11:27 PM, Samantha N. Bueno wrote:
> On Tue, Feb 25, 2014 at 04:49:34PM +0100, Jan Stodola wrote:
>> On 02/25/2014 03:57 PM, Samantha N. Bueno wrote:
>>> On Tue, Feb 25, 2014 at 01:06:53PM +0100, Jan Stodola wrote:
>>>> Samantha,
>>>> does it mean that anaconda will format all unformatted disks without
>>>> asking? It looks so from the video and in my opinion this should not
>>>> happen, anaconda should ask.
>>> All disks, no; just the ones which are selected. Since one could have
>>> many disks which are unformatted, and since it is time-consuming to run
>>> dasdfmt especially as your number of disks grows, it was decided to not
>>> blanket dasdfmt all of them, especially since a user might not wish to
>>> use all of them.
>> I meant a bit different issue - I will describe better:
>>
>> The main hub says "We won't touch your disks until you click 'Begin
>> Installation'". In the Installation Destination spoke you selected 4
>> disks and clicked "Done". What happened: anaconda started formatting
>> selected unformatted disks - immediately, without any warning! What
>> I would expect to see is a window saying something like:
> I don't like the idea of popping up yet another dialog box for someone
> to click a button so things can proceed. I am going to make sure that in
> the s390x installation guide, this behavior is mentioned specifically so
> that it won't (read: shouldn't) be a surprise.

It is not yet another dialog box, you can just use the dialog box you 
already implemented, but use the button "OK" to start the formatting. 
This way, user will have a chance to notice that something dangerous is 
going to happen with the disk(s).
I think it is much better to ask the user rather than documenting the 
automatic formatting.

Also in RHEL-5 and RHEL-6, anaconda asks before formatting such disks.

>
> I am even ok with amending the text on the main hub to say, "We won't
> touch your disks until you click 'Begin Installation', with the
> exception of DASDs requiring dasdfmt." (Only for s390x installs of
> course.)
>
> To me it seems that if you have selected a disk that you want to use
> during installation, it's implied that you want to render it *usable*
> such that anaconda can actually utilize it.
>
> Samantha
>   
>> ---------------------------------------------------------------
>> There are 2 uninitialized DASD devices selected:
>> /dev/disk/by-path/ccw-0.0.3627
>> /dev/disk/by-path/ccw-0.0.3727
>>
>> To continue installation, the devices must be formatted. Formatting
>> will remove any data on these devices.
>> Format uninitialized DASD devices?
>>
>> <Cancel> <Format>
>> ----------------------------------------------------------------
>>
>> Cancel will return to the Initial Destination spoke without
>> formatting, OK (or Format?) button will start the formatting.
>> _______________________________________________
>> anaconda-patches mailing list
>> anaconda-patches at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


-- 
Jan Stodola
Quality Assurance Engineer

Red Hat Czech s.r.o., Purkynova 99/71, 612 45  Brno, Czech Republic
Email: jstodola at redhat.com



More information about the anaconda-patches mailing list