[anaconda/blivet][master/rhel7-branch] DASD storage re-write, take II

Samantha N. Bueno sbueno+anaconda at redhat.com
Tue Feb 25 15:15:17 UTC 2014


On Tue, Feb 25, 2014 at 01:19:05PM +0100, Vratislav Podzimek wrote:
> On Tue, 2014-02-25 at 04:30 -0500, Samantha N. Bueno wrote:
> > This includes fixes suggested from the first review. The flow of this
> > is also a bit different from when I first posted as well, thanks to
> > discussions with dlehman and mizmo (read: simpler and less clunky).
> > The text install is basically the same, but for an updated screencast
> > of the graphical version here's a link:
> > http://sbueno.fedorapeople.org/1001070-graphical-25feb.webm
> > 
> > jstodola mentioned the "zerombr" kickstart command last time; support
> > for that is here; if "zerombr" is in a ks file and unformatted DASDs are
> > specified, they automatically have dasdfmt run against them.
> > 
> > A few points that are sort of minor but which bug me, all graphical:
> > * The link on the dialog box back to the summary hub doesn't work, so I
> >   sort of force it myself in what's probably a less correct way. I'm not
> >   sure what format the URI should be, so if anyone knows, let me know.
> I'm afraid the way you do it is the only working one.

Eh, well that's fine. Just figured there's likely another way.

> > 
> > * Again following a return to the summary hub, while letting dasdfmt run
> >   in the background, the UI sort of freezes up; I'm guessing I need some
> >   sort of decorator somewhere, maybe?
> Does it freeze for the time DASDs being formated? 

Yes.

> > 
> > * I think my thread handling is jumbled and awkward in places (GUI
> >   storage), then again trying to cleanly work in the "zerombr" command
> >   was no picnic. I'd be greatly in favor of only allowing "zerombr" as
> >   valid if in text mode; the graphical code is hideous IMO.
> I think it's not that bad even in the GUI code. :)

Ah you should've seen it before I'd trimmed things and squashed tmp
patches. ;) The graphical "zerombr" stuff is still not perfect with the
status notifications though so I'll likely re-post that once I figure it
out.

Samantha

> -- 
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list