[anaconda/blivet][master/rhel7-branch] DASD storage re-write, take II

Jan Stodola jstodola at redhat.com
Tue Feb 25 12:06:53 UTC 2014


Samantha,
does it mean that anaconda will format all unformatted disks without 
asking? It looks so from the video and in my opinion this should not 
happen, anaconda should ask.

Another issue - after the formatting is finished, you are returned to 
main hub, so you have to enter the Installation destination spoke again 
- is it necessary to return to main hub? Also note that main hub says 
"No disks selected", but the "Begin Installation" button is enabled, 
which also doesn't look right.

Thanks for working on the "zerombr" kickstart command.

Jan

On 02/25/2014 10:30 AM, Samantha N. Bueno wrote:
> This includes fixes suggested from the first review. The flow of this
> is also a bit different from when I first posted as well, thanks to
> discussions with dlehman and mizmo (read: simpler and less clunky).
> The text install is basically the same, but for an updated screencast
> of the graphical version here's a link:
> http://sbueno.fedorapeople.org/1001070-graphical-25feb.webm
>
> jstodola mentioned the "zerombr" kickstart command last time; support
> for that is here; if "zerombr" is in a ks file and unformatted DASDs are
> specified, they automatically have dasdfmt run against them.
>
> A few points that are sort of minor but which bug me, all graphical:
> * The link on the dialog box back to the summary hub doesn't work, so I
>    sort of force it myself in what's probably a less correct way. I'm not
>    sure what format the URI should be, so if anyone knows, let me know.
>
> * Again following a return to the summary hub, while letting dasdfmt run
>    in the background, the UI sort of freezes up; I'm guessing I need some
>    sort of decorator somewhere, maybe?
>
> * I think my thread handling is jumbled and awkward in places (GUI
>    storage), then again trying to cleanly work in the "zerombr" command
>    was no picnic. I'd be greatly in favor of only allowing "zerombr" as
>    valid if in text mode; the graphical code is hideous IMO.


More information about the anaconda-patches mailing list