[PATCH 0/4] Peck away at some more of the C code in isys

Will Woods wwoods at redhat.com
Mon Feb 24 20:47:29 UTC 2014


On Mon, 2014-02-24 at 09:27 -0500, David Shea wrote:
> This leaves in isys.c: a call to sync(), a call to settimeofday(), a function
> that returns the version from some CFLAGS, and a SIGSEGV handler. The first can
> be removed when we move to Python 3.
> 
> David Shea (4):
>   Convert isys.isIsoImage to python code
>   Remove isys.isPseudoTTY
>   Added a note about when and how to remove isys.sync
>   Remove a bunch of unused includes and tests for headers
> 
>  configure.ac                | 50 ++---------------------------
>  pyanaconda/isys/Makefile.am | 16 ++--------
>  pyanaconda/isys/__init__.py | 17 +++++++---
>  pyanaconda/isys/isofs.c     | 57 ---------------------------------
>  pyanaconda/isys/isys.c      | 77 +--------------------------------------------
>  pyanaconda/isys/isys.h      | 31 ------------------
>  widgets/configure.ac        |  2 +-
>  7 files changed, 20 insertions(+), 230 deletions(-)
>  delete mode 100644 pyanaconda/isys/isofs.c
>  delete mode 100644 pyanaconda/isys/isys.h
> 

These all look fine. ACK!

-w

(An aside: we could probably replace the CFLAGS stuff with a little
autoconf junk somewhere else and use ctypes to call settimeofday().. 

Not really sure about that SIGSEGV handler though. But surely we can do
that in Python these days?)



More information about the anaconda-patches mailing list