[blivet:rhel7/master] Make partitioning error message more friendly (#1020388)

Anne Mulhern amulhern at redhat.com
Thu Feb 20 20:26:56 UTC 2014





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Thursday, February 20, 2014 1:26:54 PM
> Subject: Re: [blivet:rhel7/master] Make partitioning error message more	friendly (#1020388)
> 
> On Thu, 2014-02-20 at 12:11 -0500, mulhern wrote:
> > Resolves: rhbz#1020388
> > 
> > Automatic partitioning is complicated and may fail for a number of reasons
> > besides an absolute lack of space. This message is supposed to be soothing
> > yet useful.
> > ---
> >  blivet/partitioning.py | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/blivet/partitioning.py b/blivet/partitioning.py
> > index 0076411..605f09f 100644
> > --- a/blivet/partitioning.py
> > +++ b/blivet/partitioning.py
> > @@ -1077,7 +1077,11 @@ def allocatePartitions(storage, disks, partitions,
> > freespace):
> >                  break
> >  
> >          if free is None:
> > -            raise PartitioningError(_("unable to allocate a large enough
> > partition"))
> > +            raise PartitioningError(
> > +               _("Unable to allocate requested partition scheme. "
> > +                 "Consider reducing the size of any already allocated "
> > +                 "partitions. If you are installing to disks of different
> > "
> > +                 "sizes, consider placing the larger disks first."))
> >  
> >          _disk = use_disk
> >          disklabel = _disk.format
> 
> I like the first line, but I'm not sure if the other lines will be
> relevant to users other than the reporter of the referenced bug. I think
> it would be better if we don't go down the path of trying to list
> possible steps to getting partitioning to come out right. It will become
> such a long list as to be useless to most users.
> 
> David
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Last two lines removed in working copy.

- mulhern



More information about the anaconda-patches mailing list