[blivet:rhel7/master] Remove sibling physical and logical volume actions (#1043763)
Anne Mulhern
amulhern at redhat.com
Thu Feb 20 15:25:16 UTC 2014
----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Thursday, February 20, 2014 9:51:17 AM
> Subject: Re: [blivet:rhel7/master] Remove sibling physical and logical volume actions (#1043763)
>
> On Thu, 2014-02-20 at 08:19 -0500, mulhern wrote:
> > Related: rhbz#1043763
> >
> > If a disk with a physical volume belonging to volume group A is hidden,
> > then the actions associated with the other logical volumes and physical
> > volumes belonging to volume group A are removed.
> > ---
> > blivet/devicetree.py | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/blivet/devicetree.py b/blivet/devicetree.py
> > index 8a79f14..099770a 100644
> > --- a/blivet/devicetree.py
> > +++ b/blivet/devicetree.py
> > @@ -1803,7 +1803,9 @@ class DeviceTree(object):
> > device.id))
> >
> > for action in reversed(self._actions):
> > - if not action.device.dependsOn(device) and action.device !=
> > device:
> > + if not (action.device.dependsOn(device) or \
> > + isinstance(device, LVMVolumeGroupDevice) and (action.device
> > in device.pvs or action.device in device.lvs) or \
>
> It would improve clarity if you enclosed the above line in parentheses.
>
Fixed in working copy.
- mulhern
More information about the anaconda-patches
mailing list