[PATCH] Don't use positional arguments to initialize Gtk objects

Brian C. Lane bcl at redhat.com
Tue Feb 18 03:36:37 UTC 2014


On Mon, Feb 17, 2014 at 06:02:21PM -0500, David Shea wrote:
> +            label = Gtk.Label(label="<span font-desc=\"Sans 14\">%s</span>" % escape_markup(_(obj.title)),
> +                    use_markup=True, halign=Gtk.Align.START, margin_top=12, margin_bottom=12)

I think the seconds line is easier to read if it is aligned with the
first argument instead of the method call.

Other than that nitpick these all look good to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list