[master][PATCH] There is no firstboot on Fedora
Anne Mulhern
amulhern at redhat.com
Mon Feb 17 13:50:28 UTC 2014
----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, February 17, 2014 8:06:05 AM
> Subject: Re: [master][PATCH] There is no firstboot on Fedora
>
> On Mon, 2014-02-17 at 07:46 -0500, Anne Mulhern wrote:
> >
> >
> >
> > ----- Original Message -----
> > > From: "Vratislav Podzimek" <vpodzime at redhat.com>
> > > To: anaconda-patches at lists.fedorahosted.org
> > > Sent: Monday, February 17, 2014 3:01:57 AM
> > > Subject: [master][PATCH] There is no firstboot on Fedora
> > >
> > > Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> > > ---
> > > pyanaconda/kickstart.py | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> > > index 7a2206c..1b2f387 100644
> > > --- a/pyanaconda/kickstart.py
> > > +++ b/pyanaconda/kickstart.py
> > > @@ -600,9 +600,8 @@ class Firstboot(commands.firstboot.FC3_Firstboot):
> > > f = open(ROOT_PATH + "/etc/reconfigSys", "w+")
> > > f.close()
> > >
> > > - iutil.execWithRedirect("systemctl", [action,
> > > "firstboot-graphical.service",
> > > -
> > > "initial-setup-graphical.service",
> > > -
> > > "initial-setup-text.service"],
> > > + iutil.execWithRedirect("systemctl", [action,
> > > "initial-setup-graphical.service",
> > > +
> > > "initial-setup-text.service"],
> > > root=ROOT_PATH)
> > >
> > > class Group(commands.group.F12_Group):
> > > --
> > > 1.8.5.3
> > >
> > > _______________________________________________
> > > anaconda-patches mailing list
> > > anaconda-patches at lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > >
> >
> > Don't we have some way to make things conditional on what OS is running?
> We do have installclasses, but in this case simply getting rid of the
> reference to a deprecated utility is a better way to go I think.
>
> --
> Vratislav Podzimek
>
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>
Oh, well if it's going away for good, I'ld stick that in the commit message.
- mulhern
More information about the anaconda-patches
mailing list