[blivet:rhel7/master 0/6] Make filesystem labeling tests not run when necessary utilities are missing from the environment

mulhern amulhern at redhat.com
Sat Feb 15 18:52:25 UTC 2014


The rundown is
* Change a few...this step is mechanical and all in formats/fs.py so should be
safe.
* Make DeviceFormat.supported...this is a little more dramatic because supported
appears higher in the class hierarchy and is used more often in the code.
Also, it's used in anaconda, so requires a mechanical anaconda patch as well.
Should be mechanical, however.
* Move SwapSpace tests...trivial.
* Refactor labeling tests...the step that means I'm removing more code than I'm
adding!
* Filesystem labeling tests...fixes the problem, efficiently.
Without the refactoring there would have been way too many new annotations.
* Rename misc_test.py...high time this happened.

*** BLURB HERE ***

mulhern (6):
  Change a few instance methods to class methods (#1065422)
  Make DeviceFormat.supported a class method (#1065422)
  Move SwapSpace tests into a separate class (#1065422)
  Refactor labeling tests (#1065422)
  Filesystem labeling tests will not run without utilities (#1065422)
  Rename misc_test.py to something more descriptive (#1065422)

 blivet/__init__.py                  |   2 +-
 blivet/formats/__init__.py          |  12 +-
 blivet/formats/biosboot.py          |   4 +-
 blivet/formats/fs.py                | 112 +++++------
 blivet/formats/prepboot.py          |   4 +-
 tests/formats_test/fslabeling.py    | 169 +++++++++++++++++
 tests/formats_test/labeling_test.py | 153 +++++++++++++++
 tests/formats_test/misc_test.py     | 364 ------------------------------------
 8 files changed, 389 insertions(+), 431 deletions(-)
 create mode 100644 tests/formats_test/fslabeling.py
 create mode 100755 tests/formats_test/labeling_test.py
 delete mode 100755 tests/formats_test/misc_test.py

-- 
1.8.3.1



More information about the anaconda-patches mailing list