[blivet/anaconda][master/rhel7-branch] DASD storage code re-write (#1001070, #859997)
Vratislav Podzimek
vpodzime at redhat.com
Wed Feb 12 10:59:01 UTC 2014
On Tue, 2014-02-11 at 18:01 -0500, Samantha N. Bueno wrote:
> The commit msgs tell all, but essentially:
> -- The blivet patches get rid of a lot of clunky code that was used to
> handle DASDs, some of which depended upon old, pre-rewrite anaconda
> itself. Now everything is nicely consolidated and sitting in
> blivet.devicelibs, and it does not depend on anaconda.
>
> -- The anaconda patches add logic such that upon entering the storage
> spoke, if (a) you're on s390x and (b) you've got unformatted DASDs,
> a dialog box pops up to warn the user and give them the option of
> running dasdfmt against them (or opting not to and just going back to
> the storage spoke).
> I discussed this with dlehman, and there really is no way to avoid
> touching these disks before 'Begin Installation' is clicked. Hence, a
> dialog box. And hence, disks are touched early on. Alas, alack.
>
> Screencasts are here, for graphical and text:
> http://sbueno.fedorapeople.org/1001070-graphical.webm
> http://sbueno.fedorapeople.org/1001070-text.webm
In general, I think it's really nice!
>
> There are some obvious issues with the graphical behavior (see
> screencast), which I could use some help with, namely:
> -- Pressing the 'format' button doesn't show the spinner until actual
> formatting is nearly complete, so it looks like anaconda is stuck.
This is probably off-topic now with the suggestion to show progress that
would require some more "threading wisdom", but I believe decorating the
callback of the button with '@timed_action' from pyanaconda.ui.gui.utils
(master) and using small values of delay and threshold should be an
improvement.
> -- The warning label about unformatted DASDs doesn't just disappear
> after formatting them.
Is the refresh method calling self.clear_info() and at its beginning and
self.window.show_all() at its end?
Other than the few comments these all look good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list