[PATCH] ListStore.remove expects an iter, not an int (#1062752).

Chris Lumens clumens at redhat.com
Tue Feb 11 21:15:19 UTC 2014


---
 pyanaconda/ui/gui/spokes/custom.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index c040730..2f2422a 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -2486,19 +2486,24 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
                 container.format.label = self._device_container_name
 
         container_exists = getattr(container, "exists", False)
+        found = None
+
         for idx, data in enumerate(self._containerStore):
             # we're looking for the original vg name
             if data[0] == container_name:
-                self._containerStore.remove(idx)
-
                 c = self.__storage.devicetree.getDeviceByName(self._device_container_name)
                 freeSpace = self._device_container_name.getattr(c, "freeSpace", None)
 
                 self._containerStore.insert(idx, self._container_store_row(freeSpace))
                 self._containerCombo.set_active(idx)
                 self._modifyContainerButton.set_sensitive(not container_exists)
+
+                found = idx
                 break
 
+        if found:
+            self._containerStore.remove(self._containerStore.get_iter_from_string("%s" % found))
+
         self._update_selectors()
 
     def on_container_changed(self, combo):
-- 
1.8.3.1



More information about the anaconda-patches mailing list