[PATCH rhel7-branch] Allow specifying an environment in the kickstart file (#1050994).

Vratislav Podzimek vpodzime at redhat.com
Tue Feb 11 09:35:28 UTC 2014


On Wed, 2014-02-05 at 10:32 -0500, Chris Lumens wrote:
> > > diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
> > > index 4b4a226..3cff8eb 100644
> > > --- a/pyanaconda/packaging/yumpayload.py
> > > +++ b/pyanaconda/packaging/yumpayload.py
> > > @@ -1367,6 +1367,8 @@ reposdir=%s
> > >  
> > >          if self.data.packages.default and self.environments:
> > >              self.selectEnvironment(self.environments[0])
> > > +        elif self.data.packages.environment:
> > > +            self.selectEnvironment(self.data.packages.environment)
> > Shouldn't self.data.packages.environment have a higher priority than
> > self.data.packages.default? I believe users would expect the code to
> > behave this way.
> 
> I don't really know that there are any expectations one way or the other
> here.  I'm having a hard time forming an argument for either way it
> should go, and I've already patched it the one way.
Okay to me, I'm quite sure there would be somebody complaining in any
case, anyway.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list