[rhel7-branch] Mark language search string translatable. (#955229)

Brian C. Lane bcl at redhat.com
Tue Feb 11 00:56:03 UTC 2014


On Mon, Feb 10, 2014 at 05:35:24PM -0500, Samantha N. Bueno wrote:
> On Tue, May 07, 2013 at 10:52:41AM -0400, Samantha N. Bueno wrote:
> > ---
> >  pyanaconda/ui/gui/spokes/welcome.glade | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/pyanaconda/ui/gui/spokes/welcome.glade b/pyanaconda/ui/gui/spokes/welcome.glade
> > index f0a4602..4f79b7c 100644
> > --- a/pyanaconda/ui/gui/spokes/welcome.glade
> > +++ b/pyanaconda/ui/gui/spokes/welcome.glade
> > @@ -367,7 +367,7 @@
> >                              <property name="invisible_char">???</property>
> >                              <property name="invisible_char_set">True</property>
> >                              <property name="secondary_icon_name">edit-clear-symbolic</property>
> > -                            <property name="placeholder_text">Type here to search.</property>
> > +                            <property name="placeholder_text" translatable="yes">Type here to search.</property>
> >                              <signal name="changed" handler="on_entry_changed" swapped="no"/>
> >                              <signal name="icon-release" handler="on_clear_icon_clicked" swapped="no"/>
> >                            </object>
> > -- 
> > 1.7.11.7
> 
> This patch got eaten at some point between May and February, and the bug
> failed qa. I'm guessing this file was re-run through glade and the
> translation notation was trashed. Chris mentioned this might happen when
> I originally posted this.
> 
> So, I guess consider this a re-post of the patch for an ack. Though I'm
> really more curious if there is a way to ensure it won't get eaten at
> some point in the future (again).

Ack.

I try to read the glade diffs, but sometimes it isn't obvious that a
change wasn't intentional. It looks like all instances of
placeholder_text should be translatable so maybe it needs a glade test.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list